Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macros): 🎸 support path to declare widget type #606

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Jun 22, 2024

Purpose of this Pull Request

Improved widget declaration to allow specifying widget types via path.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jun 22, 2024
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jun 22, 2024
@M-Adoo M-Adoo enabled auto-merge June 22, 2024 08:17
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jun 22, 2024
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.44%. Comparing base (abd5c6f) to head (ddfb488).
Report is 21 commits behind head on master.

Files Patch % Lines
macros/src/symbol_process.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   83.56%   83.44%   -0.13%     
==========================================
  Files         185      186       +1     
  Lines       25692    25599      -93     
==========================================
- Hits        21470    21360     -110     
- Misses       4222     4239      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Adoo M-Adoo disabled auto-merge June 22, 2024 08:57
@M-Adoo M-Adoo merged commit 411307b into RibirX:master Jun 22, 2024
16 of 17 checks passed
@M-Adoo M-Adoo deleted the feat/path-widget branch June 22, 2024 08:57
@M-Adoo M-Adoo restored the feat/path-widget branch June 22, 2024 08:58
@M-Adoo M-Adoo deleted the feat/path-widget branch July 15, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant